Re: [PATCH 6/8] qemuDomainVirStorageSourceFindByNodeName: Extract nodename matching

On Thu, Nov 28, 2024 at 10:22:53 +0100, Jiri Denemark wrote: > On Tue, Nov 26, 2024 at 16:16:17 +0100, Peter Krempa wrote: > > Extract the matching of the node name of a single virStorage source so > > that the logic can be extended in the upcoming patch. > > This is confusing. I was expecting the logic in > qemuDomainVirStorageSourceFindByNodeName to be extended in the following > patch, but in reality you just needed to reuse the same code in another > place. That is the goal of moving the code to a separate function was to > avoid code duplication. so s/extended/reused/ ?