Re: [libvirt PATCH 23/23] build: add syntax-check rules for undesirable terms
On Fri, Jun 19, 2020 at 12:47:07PM +0200, Peter Krempa wrote:
On Fri, Jun 19, 2020 at 10:33:00 +0100, Daniel Berrange wrote:
> We don't check for "master", because there are too many
> cases that we're not trying to eliminate at this time.
>
> Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com>
> ---
> build-aux/syntax-check.mk | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
I don't think there's a technical reason forbiding these and it's almost
borderline censorship. I refuse to put my R-b on this one.
Few of the syntax check rules are technical in nature. They're largely
about enforcing our desired coding/style policies. Preventing reintroduction
of terminology we've just eliminated is totally in scope for what syntax
check does. The goal is to automate checks that humans are otherwise bad
at doing, because we'll easily miss this kind of thing in manual reviews.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|