Re: [libvirt] [PATCH v2 0/2] tests: Add nodeinfo test data utility scripts
On 10/07/2015 08:57 AM, Andrea Bolognani wrote:
Changes from v1:
* use a better approach to copy host data (thanks Martin)
* acknowledge the fact that the scripts require bash
* other small cleanups and improvements
Andrea Bolognani (2):
tests: Add script to display nodeinfo test data
tests: Add script to copy nodeinfo test data from host
tests/nodeinfodata/copy-from-host.sh | 113 +++++++++++++++++++++++++++++++++++
tests/nodeinfodata/display.sh | 113 +++++++++++++++++++++++++++++++++++
2 files changed, 226 insertions(+)
create mode 100755 tests/nodeinfodata/copy-from-host.sh
create mode 100755 tests/nodeinfodata/display.sh
I'm ambivalent on this pair.
Not sure what the value of patch 1 is? What should I expect to see
given the arguments? What does "ppc64_cpu --info" show? Perhaps the
better question is - if you run on each directory in nodeinfodata do you
get what you expect?
As for patch 2, one would have to know they should use the
copy-from-host.sh script. Perhaps what might be better and/or somewhat
more interesting on this one is some make check rule that scans the
nodeinfodata trees looking for files that shouldn't be there. That way
if someone does use their own methodology to copy over the tree we'd
know it (and could message to use the copy-from-host.sh script...
John