Re: [libvirt] [PATCH 02/10] Make virDomainObjParseFile and virDomainObjParseNode static.
On Mon, Apr 26, 2010 at 12:07:17PM -0400, Chris Lalancette wrote:
On 04/22/2010 08:03 AM, Daniel P. Berrange wrote:
> On Wed, Apr 21, 2010 at 12:01:16PM -0400, Chris Lalancette wrote:
>> Signed-off-by: Chris Lalancette <clalance(a)redhat.com>
>> ---
>> src/conf/domain_conf.c | 37 +++++++++++++++++++------------------
>> src/conf/domain_conf.h | 6 ------
>> 2 files changed, 19 insertions(+), 24 deletions(-)
>
>
> What's the reason for making these static ?
They aren't currently used outside of domain_conf.c, so I
figured I would just restrict them to the file. It's not really
required for the patchset, just a cleanup.
Ok, I'd rather we leave them as is then. Usage of internal APIs changes
over time, so its just code churn to switch between static & non-static
every time usage happens to change.
Regards,
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|