Re: [libvirt] [perl PATCH] Switch over to using Module::Build

15 May 2018


      On Tue, May 15, 2018 at 08:17:09PM +0200, Andrea Bolognani wrote:
...
On Tue, 2018-05-15 at 18:55 +0100, Daniel P. Berrangé wrote:
...
On Tue, May 15, 2018 at 07:23:28PM +0200, Andrea Bolognani wrote:
...
Lastly, the RPM build fails with
RPM build errors:
      Empty %files file /home/test/libvirt-perl/rpmbuild/BUILD/Sys-Virt-v4.4.0/debugsourcefiles.list
on Fedora. It passes on CentOS 7, though.
Rather strange - i have no trouble with that on Fedora 28 at least.
How were you triggering the RPM build ?  I wonder if perhaps there was
any stale files from MakeMaker causing it ?
I made sure the source tree was git clean'd before starting the
build.
Note that I'm testing this in guests which have been created using
the same steps as the ones in the CentOS CI environment, so it's
pretty likely that something on your system is masking the failure.
I'm attaching the rpmbuild output, maybe you'll find something
useful in there.
Is redhat-rpm-config installed ?
...
+ /usr/bin/perl Build.PL installdirs=vendor
Created MYMETA.yml and MYMETA.json
Creating new 'Build' script for 'Sys-Virt' version 'v4.4.0'
+ ./Build
Building Sys-Virt
ExtUtils::Mkbootstrap::Mkbootstrap('blib/arch/auto/Sys/Virt/Virt.bs')
gcc -lpthread -shared -Wl,-z,relro -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -L/usr/local/lib -fstack-protector-strong -lperl -o blib/arch/auto/Sys/Virt/Virt.so lib/Sys/Virt.o -L/home/test/build/lib
virt/lib -lvirt
This is suspect - on mine it is much longer - in particular it has
the -g flag for creating debuginfo packages


+ /usr/bin/perl Build.PL installdirs=vendor
Created MYMETA.yml and MYMETA.json
Creating new 'Build' script for 'Sys-Virt' version 'v4.4.0'
+ ./Build
Building Sys-Virt
gcc -I/usr/lib64/perl5/CORE -DVERSION="v4.4.0" -DXS_VERSION="v4.4.0" -fPIC -I/home/berrange/src/virt/libvirt/include -c -D_REENTRANT -D_GNU_SOURCE -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -mcet -fcf-protection -fwrapv -fno-strict-aliasing -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -g -o lib/Sys/Virt.o lib/Sys/Virt.c
ExtUtils::Mkbootstrap::Mkbootstrap('blib/arch/auto/Sys/Virt/Virt.bs')
gcc -lpthread -shared -Wl,-z,relro -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -L/usr/local/lib -fstack-protector-strong -lperl -o blib/arch/auto/Sys/Virt/Virt.so lib/Sys/Virt.o -L/home/berrange/src/virt/libvirt/src/.libs -lvirt
...
+ exit 0
Executing(%install): /bin/sh -e /var/tmp/rpm-tmp.A9ONYC
+ umask 022
+ cd /home/test/libvirt-perl/rpmbuild/BUILD
+ '[' /home/test/libvirt-perl/rpmbuild/BUILDROOT/perl-Sys-Virt-4.4.0-1.fc28.x86_64 '!=' / ']'
+ rm -rf /home/test/libvirt-perl/rpmbuild/BUILDROOT/perl-Sys-Virt-4.4.0-1.fc28.x86_64
++ dirname /home/test/libvirt-perl/rpmbuild/BUILDROOT/perl-Sys-Virt-4.4.0-1.fc28.x86_64
+ mkdir -p /home/test/libvirt-perl/rpmbuild/BUILDROOT
+ mkdir /home/test/libvirt-perl/rpmbuild/BUILDROOT/perl-Sys-Virt-4.4.0-1.fc28.x86_64
+ cd Sys-Virt-v4.4.0
+ ./Build install destdir=/home/test/libvirt-perl/rpmbuild/BUILDROOT/perl-Sys-Virt-4.4.0-1.fc28.x86_64 create_packlist=0
Building Sys-Virt
Files found in blib/arch: installing files in blib/lib into architecture dependent library tree
Installing /home/test/libvirt-perl/rpmbuild/BUILDROOT/perl-Sys-Virt-4.4.0-1.fc28.x86_64/usr/lib64/perl5/vendor_perl/auto/Sys/Virt/Virt.so
Installing /home/test/libvirt-perl/rpmbuild/BUILDROOT/perl-Sys-Virt-4.4.0-1.fc28.x86_64/usr/lib64/perl5/vendor_perl/auto/Sys/Virt/Virt.bs
Installing /home/test/libvirt-perl/rpmbuild/BUILDROOT/perl-Sys-Virt-4.4.0-1.fc28.x86_64/usr/lib64/perl5/vendor_perl/Sys/Virt.pm
Installing /home/test/libvirt-perl/rpmbuild/BUILDROOT/perl-Sys-Virt-4.4.0-1.fc28.x86_64/usr/lib64/perl5/vendor_perl/Sys/Virt/Event.pm
Installing /home/test/libvirt-perl/rpmbuild/BUILDROOT/perl-Sys-Virt-4.4.0-1.fc28.x86_64/usr/lib64/perl5/vendor_perl/Sys/Virt/Network.pm
Installing /home/test/libvirt-perl/rpmbuild/BUILDROOT/perl-Sys-Virt-4.4.0-1.fc28.x86_64/usr/lib64/perl5/vendor_perl/Sys/Virt/Stream.pm
Installing /home/test/libvirt-perl/rpmbuild/BUILDROOT/perl-Sys-Virt-4.4.0-1.fc28.x86_64/usr/lib64/perl5/vendor_perl/Sys/Virt/Interface.pm
Installing /home/test/libvirt-perl/rpmbuild/BUILDROOT/perl-Sys-Virt-4.4.0-1.fc28.x86_64/usr/lib64/perl5/vendor_perl/Sys/Virt/NWFilter.pm
Installing /home/test/libvirt-perl/rpmbuild/BUILDROOT/perl-Sys-Virt-4.4.0-1.fc28.x86_64/usr/lib64/perl5/vendor_perl/Sys/Virt/NodeDevice.pm
Installing /home/test/libvirt-perl/rpmbuild/BUILDROOT/perl-Sys-Virt-4.4.0-1.fc28.x86_64/usr/lib64/perl5/vendor_perl/Sys/Virt/StorageVol.pm
Installing /home/test/libvirt-perl/rpmbuild/BUILDROOT/perl-Sys-Virt-4.4.0-1.fc28.x86_64/usr/lib64/perl5/vendor_perl/Sys/Virt/DomainSnapshot.pm
Installing /home/test/libvirt-perl/rpmbuild/BUILDROOT/perl-Sys-Virt-4.4.0-1.fc28.x86_64/usr/lib64/perl5/vendor_perl/Sys/Virt/StoragePool.pm
Installing /home/test/libvirt-perl/rpmbuild/BUILDROOT/perl-Sys-Virt-4.4.0-1.fc28.x86_64/usr/lib64/perl5/vendor_perl/Sys/Virt/Domain.pm
Installing /home/test/libvirt-perl/rpmbuild/BUILDROOT/perl-Sys-Virt-4.4.0-1.fc28.x86_64/usr/lib64/perl5/vendor_perl/Sys/Virt/Secret.pm
Installing /home/test/libvirt-perl/rpmbuild/BUILDROOT/perl-Sys-Virt-4.4.0-1.fc28.x86_64/usr/lib64/perl5/vendor_perl/Sys/Virt/Error.pm
Installing /home/test/libvirt-perl/rpmbuild/BUILDROOT/perl-Sys-Virt-4.4.0-1.fc28.x86_64/usr/share/man/man3/Sys::Virt::Stream.3pm
Installing /home/test/libvirt-perl/rpmbuild/BUILDROOT/perl-Sys-Virt-4.4.0-1.fc28.x86_64/usr/share/man/man3/Sys::Virt::Domain.3pm
Installing /home/test/libvirt-perl/rpmbuild/BUILDROOT/perl-Sys-Virt-4.4.0-1.fc28.x86_64/usr/share/man/man3/Sys::Virt::Error.3pm
Installing /home/test/libvirt-perl/rpmbuild/BUILDROOT/perl-Sys-Virt-4.4.0-1.fc28.x86_64/usr/share/man/man3/Sys::Virt::NWFilter.3pm
Installing /home/test/libvirt-perl/rpmbuild/BUILDROOT/perl-Sys-Virt-4.4.0-1.fc28.x86_64/usr/share/man/man3/Sys::Virt::Secret.3pm
Installing /home/test/libvirt-perl/rpmbuild/BUILDROOT/perl-Sys-Virt-4.4.0-1.fc28.x86_64/usr/share/man/man3/Sys::Virt::Interface.3pm
Installing /home/test/libvirt-perl/rpmbuild/BUILDROOT/perl-Sys-Virt-4.4.0-1.fc28.x86_64/usr/share/man/man3/Sys::Virt::NodeDevice.3pm
Installing /home/test/libvirt-perl/rpmbuild/BUILDROOT/perl-Sys-Virt-4.4.0-1.fc28.x86_64/usr/share/man/man3/Sys::Virt::Network.3pm
Installing /home/test/libvirt-perl/rpmbuild/BUILDROOT/perl-Sys-Virt-4.4.0-1.fc28.x86_64/usr/share/man/man3/Sys::Virt::StorageVol.3pm
Installing /home/test/libvirt-perl/rpmbuild/BUILDROOT/perl-Sys-Virt-4.4.0-1.fc28.x86_64/usr/share/man/man3/Sys::Virt::DomainSnapshot.3pm
Installing /home/test/libvirt-perl/rpmbuild/BUILDROOT/perl-Sys-Virt-4.4.0-1.fc28.x86_64/usr/share/man/man3/Sys::Virt::StoragePool.3pm
Installing /home/test/libvirt-perl/rpmbuild/BUILDROOT/perl-Sys-Virt-4.4.0-1.fc28.x86_64/usr/share/man/man3/Sys::Virt.3pm
Installing /home/test/libvirt-perl/rpmbuild/BUILDROOT/perl-Sys-Virt-4.4.0-1.fc28.x86_64/usr/share/man/man3/Sys::Virt::Event.3pm
+ /usr/bin/chmod -Rf a+rX,u+w,g-w,o-w /home/test/libvirt-perl/rpmbuild/BUILDROOT/perl-Sys-Virt-4.4.0-1.fc28.x86_64/usr
+ /usr/lib/rpm/find-debuginfo.sh -j2 --strict-build-id -m -i --build-id-seed 4.4.0-1.fc28 --unique-debug-suffix -4.4.0-1.fc28.x86_64 --unique-debug-src-base perl-Sys-Virt-4.4.0-1.fc28.x86_64 --run-dwz --dwz-low-me
m-die-limit 10000000 --dwz-max-die-limit 110000000 -S debugsourcefiles.list /home/test/libvirt-perl/rpmbuild/BUILD/Sys-Virt-v4.4.0
extracting debug info from /home/test/libvirt-perl/rpmbuild/BUILDROOT/perl-Sys-Virt-4.4.0-1.fc28.x86_64/usr/lib64/perl5/vendor_perl/auto/Sys/Virt/Virt.so
/usr/lib/rpm/sepdebugcrcfix: Updated 1 CRC32s, 0 CRC32s did match.
+ /usr/lib/rpm/check-buildroot
+ /usr/lib/rpm/redhat/brp-ldconfig
/sbin/ldconfig: Warning: ignoring configuration file that cannot be opened: /etc/ld.so.conf: No such file or directory
+ /usr/lib/rpm/brp-compress
+ /usr/lib/rpm/brp-strip-static-archive /usr/bin/strip
+ /usr/lib/rpm/brp-python-bytecompile /usr/bin/python 1
+ /usr/lib/rpm/brp-python-hardlink
+ /usr/lib/rpm/redhat/brp-mangle-shebangs '' ''
Executing(%check): /bin/sh -e /var/tmp/rpm-tmp.KUl62N
+ umask 022
+ cd /home/test/libvirt-perl/rpmbuild/BUILD
+ cd Sys-Virt-v4.4.0
+ ./Build test
t/005-pod.t ............ ok
t/010-pod-coverage.t ... ok
t/015-changes.t ........ ok   
t/020-constants.t ...... ok     
t/030-api-coverage.t ... skipped: Test only for module maintainer. Set TEST_MAINTAINER=1 to run
t/100-connect.t ........ ok     
t/200-domains.t ........ ok     
t/300-networks.t ....... ok     
t/400-storage-pools.t .. ok     
t/500-storage-vols.t ... ok     
t/600-interfaces.t ..... ok     
t/800-events.t ......... ok     
All tests successful.
Files=12, Tests=252,  2 wallclock secs ( 0.09 usr  0.02 sys +  1.84 cusr  0.21 csys =  2.16 CPU)
Result: PASS
+ exit 0
Processing files: perl-Sys-Virt-4.4.0-1.fc28.x86_64
Executing(%doc): /bin/sh -e /var/tmp/rpm-tmp.o7Fpq5
+ umask 022
+ cd /home/test/libvirt-perl/rpmbuild/BUILD
+ cd Sys-Virt-v4.4.0
+ DOCDIR=/home/test/libvirt-perl/rpmbuild/BUILDROOT/perl-Sys-Virt-4.4.0-1.fc28.x86_64/usr/share/doc/perl-Sys-Virt
+ export LC_ALL=C
+ LC_ALL=C
+ export DOCDIR
+ /usr/bin/mkdir -p /home/test/libvirt-perl/rpmbuild/BUILDROOT/perl-Sys-Virt-4.4.0-1.fc28.x86_64/usr/share/doc/perl-Sys-Virt
+ cp -pr AUTHORS /home/test/libvirt-perl/rpmbuild/BUILDROOT/perl-Sys-Virt-4.4.0-1.fc28.x86_64/usr/share/doc/perl-Sys-Virt
+ cp -pr Changes /home/test/libvirt-perl/rpmbuild/BUILDROOT/perl-Sys-Virt-4.4.0-1.fc28.x86_64/usr/share/doc/perl-Sys-Virt
+ cp -pr LICENSE /home/test/libvirt-perl/rpmbuild/BUILDROOT/perl-Sys-Virt-4.4.0-1.fc28.x86_64/usr/share/doc/perl-Sys-Virt
+ cp -pr README /home/test/libvirt-perl/rpmbuild/BUILDROOT/perl-Sys-Virt-4.4.0-1.fc28.x86_64/usr/share/doc/perl-Sys-Virt
+ cp -pr examples/ /home/test/libvirt-perl/rpmbuild/BUILDROOT/perl-Sys-Virt-4.4.0-1.fc28.x86_64/usr/share/doc/perl-Sys-Virt
+ exit 0
Provides: perl-Sys-Virt = 4.4.0-1.fc28 perl-Sys-Virt(x86-64) = 4.4.0-1.fc28
Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
Requires: libc.so.6()(64bit) libc.so.6(GLIBC_2.14)(64bit) libc.so.6(GLIBC_2.2.5)(64bit) libc.so.6(GLIBC_2.4)(64bit) libperl.so.5.26()(64bit) libpthread.so.0()(64bit) libpthread.so.0(GLIBC_2.2.5)(64bit) libvirt.so.0()(64bit) libvirt.so.0(LIBVIRT_0.0.3)(64bit) libvirt.so.0(LIBVIRT_0.0.5)(64bit) libvirt.so.0(LIBVIRT_0.1.0)(64bit) libvirt.so.0(LIBVIRT_0.1.1)(64bit) libvirt.so.0(LIBVIRT_0.1.4)(64bit) libvirt.so.0(LIBVIRT_0.1.5)(64bit) libvirt.so.0(LIBVIRT_0.1.9)(64bit) libvirt.so.0(LIBVIRT_0.10.0)(64bit) libvirt.so.0(LIBVIRT_0.10.2)(64bit) libvirt.so.0(LIBVIRT_0.2.0)(64bit) libvirt.so.0(LIBVIRT_0.2.1)(64bit) libvirt.so.0(LIBVIRT_0.2.3)(64bit) libvirt.so.0(LIBVIRT_0.3.0)(64bit) libvirt.so.0(LIBVIRT_0.3.2)(64bit) libvirt.so.0(LIBVIRT_0.3.3)(64bit) libvirt.so.0(LIBVIRT_0.4.0)(64bit) libvirt.so.0(LIBVIRT_0.4.1)(64bit) libvirt.so.0(LIBVIRT_0.4.2)(64bit) libvirt.so.0(LIBVIRT_0.4.5)(64bit) libvirt.so.0(LIBVIRT_0.5.0)(64bit) libvirt.so.0(LIBVIRT_0.6.0)(64bit) libvirt.so.0(LIBVIRT_0.6.1)(64bit) libvirt.so.0(LIBVIRT_0.6.3)(64bit) libvirt.so.0(LIBVIRT_0.6.4)(64bit) libvirt.so.0(LIBVIRT_0.7.0)(64bit) libvirt.so.0(LIBVIRT_0.7.1)(64bit) libvirt.so.0(LIBVIRT_0.7.2)(64bit) libvirt.so.0(LIBVIRT_0.7.3)(64bit) libvirt.so.0(LIBVIRT_0.7.5)(64bit) libvirt.so.0(LIBVIRT_0.7.7)(64bit) libvirt.so.0(LIBVIRT_0.8.0)(64bit) libvirt.so.0(LIBVIRT_0.8.1)(64bit) libvirt.so.0(LIBVIRT_0.8.2)(64bit) libvirt.so.0(LIBVIRT_0.8.5)(64bit) libvirt.so.0(LIBVIRT_0.8.6)(64bit) libvirt.so.0(LIBVIRT_0.8.8)(64bit) libvirt.so.0(LIBVIRT_0.9.0)(64bit) libvirt.so.0(LIBVIRT_0.9.10)(64bit) libvirt.so.0(LIBVIRT_0.9.11)(64bit) libvirt.so.0(LIBVIRT_0.9.13)(64bit) libvirt.so.0(LIBVIRT_0.9.2)(64bit) libvirt.so.0(LIBVIRT_0.9.3)(64bit) libvirt.so.0(LIBVIRT_0.9.4)(64bit) libvirt.so.0(LIBVIRT_0.9.5)(64bit) libvirt.so.0(LIBVIRT_0.9.7)(64bit) libvirt.so.0(LIBVIRT_0.9.8)(64bit) libvirt.so.0(LIBVIRT_0.9.9)(64bit) libvirt.so.0(LIBVIRT_1.0.0)(64bit) libvirt.so.0(LIBVIRT_1.0.1)(64bit) libvirt.so.0(LIBVIRT_1.0.2)(64bit) libvirt.so.0(LIBVIRT_1.0.3)(64bit) libvirt.so.0(LIBVIRT_1.0.5)(64bit) libvirt.so.0(LIBVIRT_1.1.0)(64bit) libvirt.so.0(LIBVIRT_1.1.1)(64bit) libvirt.so.0(LIBVIRT_1.1.3)(64bit) libvirt.so.0(LIBVIRT_1.2.1)(64bit) libvirt.so.0(LIBVIRT_1.2.11)(64bit) libvirt.so.0(LIBVIRT_1.2.12)(64bit) libvirt.so.0(LIBVIRT_1.2.14)(64bit) libvirt.so.0(LIBVIRT_1.2.15)(64bit) libvirt.so.0(LIBVIRT_1.2.16)(64bit) libvirt.so.0(LIBVIRT_1.2.19)(64bit) libvirt.so.0(LIBVIRT_1.2.3)(64bit) libvirt.so.0(LIBVIRT_1.2.5)(64bit) libvirt.so.0(LIBVIRT_1.2.6)(64bit) libvirt.so.0(LIBVIRT_1.2.7)(64bit) libvirt.so.0(LIBVIRT_1.2.8)(64bit) libvirt.so.0(LIBVIRT_1.2.9)(64bit) libvirt.so.0(LIBVIRT_1.3.3)(64bit) libvirt.so.0(LIBVIRT_2.0.0)(64bit) libvirt.so.0(LIBVIRT_2.2.0)(64bit) libvirt.so.0(LIBVIRT_3.0.0)(64bit) libvirt.so.0(LIBVIRT_3.1.0)(64bit) libvirt.so.0(LIBVIRT_3.4.0)(64bit) libvirt.so.0(LIBVIRT_3.7.0)(64bit) libvirt.so.0(LIBVIRT_3.9.0)(64bit) libvirt.so.0(LIBVIRT_4.1.0)(64bit) rtld(GNU_HASH)
Processing files: perl-Sys-Virt-debugsource-4.4.0-1.fc28.x86_64
error: Empty %files file /home/test/libvirt-perl/rpmbuild/BUILD/Sys-Virt-v4.4.0/debugsourcefiles.list
RPM build errors:
    Empty %files file /home/test/libvirt-perl/rpmbuild/BUILD/Sys-Virt-v4.4.0/debugsourcefiles.list
Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|