On 01/10/2013 12:45 AM, Eric Blake wrote:
* libvirt.spec.in: Add some indentation to make it easier to follow various conditionals. --- libvirt.spec.in | 858 ++++++++++++++++++++++++++++---------------------------- 1 file changed, 428 insertions(+), 430 deletions(-)
# Fedora 18 / RHEL-7 are first where firewalld support is enabled %if 0%{?fedora} >= 17 || 0%{?rhel} >= 7 None of your doing, but the contradiction between comment (F18) and
Painful experience makes me agree that the unindented nested %ifs decrease the readability of the spec file and thus would be in favor of this patch. However, indentation seems to be uncustomary. On the other hand, it doesn't seem to be explicitly forbidden, looking at e.g. http://fedoraproject.org/wiki/Packaging:Guidelines Any packager here that wants to throw in 2 cents? directive (F17) should be resolved. -- Mit freundlichen Grüßen/Kind Regards Viktor Mihajlovski IBM Deutschland Research & Development GmbH Vorsitzender des Aufsichtsrats: Martina Köderitz Geschäftsführung: Dirk Wittkopp Sitz der Gesellschaft: Böblingen Registergericht: Amtsgericht Stuttgart, HRB 243294