Re: [PATCH] rpm: Enable Xen support on AArch64
On Mon, Oct 5, 2020 at 6:18 AM Andrea Bolognani <abologna(a)redhat.com> wrote:
On Sun, 2020-10-04 at 22:16 -0400, Neal Gompa wrote:
> +++ b/libvirt.spec.in
> +# Xen is available only on i386 x86_64 ia64 aarch64
> +%ifnarch %{ix86} x86_64 ia64 aarch64
> %define with_libxl 0
> %endif
The code change is okay, but duplicating the list of architectures in
the comment is kinda pointless and results in unnecessary churn; I
would reword it as
Xen is available only on some architectures
Are you okay with that change? If so, I will add my
Reviewed-by: Andrea Bolognani <abologna(a)redhat.com>
and push the patch.
I'm fine with that. I debated making that change myself, too. :)
--
真実はいつも一つ！/ Always, there's only one truth!