Re: [libvirt] [PATCH] Fix closedir usage in virNumaGetPages

On 06/21/2014 05:29 PM, Roman Bogorodskiy wrote:

virNumaGetPages calls closedir(dir) in cleanup and dir could be NULL if we jump there from the failed opendir() call.

While it's not harmful on Linux, FreeBSD libc crashes [1], so make sure that dir is not NULL before calling closedir.

1: http://lists.freebsd.org/pipermail/freebsd-standards/2014-January/002704.htm... --- src/util/virnuma.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

ACK Jan