Re: [libvirt] [PATCH 0/3] Multiple fixes related to lookup of gluster volumes

On 02/24/2014 08:21 AM, Peter Krempa wrote: I haven't seen this one in my inbox yet but did see it online (don't know where the delay is occurring). My gut reaction is that patch 3/3 is wrong, and that we should instead fix the documentation. We've already released code with 'key' being non-unique and it is likely that clients have already come to rely/deal with that. Changing what we stick in the key now without good justification may be worse than the notion of "fixing it to make things globally unique". Global uniqueness is easy for files in the local file system, but a lot harder for distributed network filesystems. So merely documenting that key may not be unique may be the better approach. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org