Re: [libvirt] [PATCH v2 00/19] Avoid races with udev
On Thu, Nov 03, 2016 at 08:18:50PM +0800, Michal Privoznik wrote:
This is v2 of:
https://www.redhat.com/archives/libvir-list/2016-October/msg01151.html
diff to v1:
- Added udev rule (patch 18/19)
- Wire the beast into spec file
- Introduced a configure argument that suppress installation of this feature
One of the problems here is that this requires patched udev:
https://github.com/systemd/systemd/commit/4f985bd80278972912b80df1390f84d...
This is going to be part of systemd-232 release. Therefore, in my code I've put
checks for 232 version.
As discussed on the previous posting, this series is still race prone as
this doesn't stop udev changing the labels on devices managed by libvirt.
It merely causes udev to change them, and then change them back again.
IMHO if we're going to require an unreleased udev, then we should work to
get an enhancement to udev so that we can avoid this relabelling entirely
and thus fully fix the race problem.
So on this basis I'm against merge of this solution as proposed.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :|