Plus libdir has to be the same in both packages anyway in order to not break the RPM build (unless you want to tweak the spec file). I'd suggest to stick to your original version (and rely on the last shot as you put it): the general case is really hard to fix properly.
Of course the only way for the plugin to be loaded by Wireshark is to install it in the directory Wireshark will load plugins for :) Sure :-)
But, as far as libvirt is concerned, it's also completely okay to install everything, including the plugin, under eg. /usr/local regardless of the fact that Wireshark will look for plugins in a sub-directory of /usr/lib. It would actually be a bug if libvirt was compiled with prefix=/usr/local and installed *anything* outside of /usr/local, unless the user provides a very specific override. Couldn't agree more.
We can't stick to the previous version because one very common use case is broken with it: passing only prefix to configure and relying on the automatically derived values for everything else. I meant your previous, already committed patch, which already had the "sentinel prefix" prepended.
I've come up with a hybrid approach that incorporates some of your suggested changes with the ones that we've come up with independently, and AFAICT handles all reasonable use cases correctly. I'll post it shortly. My email server is slow as molasses. But I've reviewed the V2 series on
On 27.10.2016 16:13, Andrea Bolognani wrote: [...] the list archive(!) and it looks fine to me.
Hope you don't mind my sticking with my own commits, it's just that the fact that I'm changing a single thing per commit makes review easier than lumping three changes together :)
Thanks for considering the comments.
-- Andrea Bolognani / Red Hat / Virtualization
-- Mit freundlichen Grüßen/Kind Regards Viktor Mihajlovski IBM Deutschland Research & Development GmbH Vorsitzender des Aufsichtsrats: Martina Köderitz Geschäftsführung: Dirk Wittkopp Sitz der Gesellschaft: Böblingen Registergericht: Amtsgericht Stuttgart, HRB 243294