23 Jan
2014
23 Jan
'14
5:12 p.m.
On 01/23/2014 02:37 PM, Daniel P. Berrange wrote:
The nwfilter conf update mutex previously serialized updates to the internal data structures for firewall rules, and updates to the firewall itself. Since the former is going to be turned into a read/write lock instead of a mutex, a new lock is required to serialize access to the firewall itself.
Again, I agree with the analysis and theory of the change, but don't think I'm qualified to ACK. I did do a make and make syntax-check successfully (after fixing the few problems in the prior patches in the series, of course) Same comment goes for 5/5.