On Tue, Sep 18, 2007 at 03:38:26AM -0400, Daniel Veillard wrote:
On Tue, Sep 18, 2007 at 02:49:01AM +0100, Daniel P. Berrange wrote:
The latest automake has a nasty habit of complaining about use of GNU Make features such as wildcards. We use these extensively in the tests/ directory since there are so many test datafiles, listing them explicitly is a waste of time.
yeah those warnings were a bit annoying.
The attached patch passes the -Wno-portability flag to automake to make it keep quiet.
NB, to do this required a bit of a re-working of the automake/autoconf initialization stuff. Our current configure script uses AC_INIT and AM_INIT_AUTOMAKE in the so called 'legacy style'.
To quote the automake manual
[quote] If your `configure.ac' has:
AC_INIT([src/foo.c]) AM_INIT_AUTOMAKE([mumble], [1.5])
you can modernize it as follows:
AC_INIT([mumble], [1.5]) AC_CONFIG_SRCDIR([src/foo.c]) AM_INIT_AUTOMAKE [/quote]
This re-arrangement is valid on any non-jurassic era automake & only impacts developers running autogen.sh - not end users running the configure script itself.
The one complication is that the version given to AC_INIT must be a literal, but we currently used an environment variable. So m4 black-magic gets around this problem.
okay +1
Ok, comitted. Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|