On 07/20/2015 09:28 AM, Olaf Hering wrote:
On Thu, Jul 16, Jim Fehlig wrote:
@@ -448,6 +438,8 @@ libxlDomainMigrationPrepare(virConnectPtr dconn, virObjectUnref(socks[i]); } VIR_FREE(socks); + virObjectUnref(args); This is now below the 'error' label, so args has to be initialized.
[ 149s] libxl/libxl_migration.c: In function 'libxlDomainMigrationPrepare': [ 149s] libxl/libxl_migration.c:463:19: warning: 'args' may be used uninitialized in this function [-Wmaybe-uninitialized] [ 149s] virObjectUnref(args); [ 149s] ^
Opps. I've squashed in the below obvious fix. Note it is safe to call virObjectUnref with a NULL object. Any other comments on this series? It fixes bugs in migration, including a possible libvirtd crash, and would be a candidate to push during freeze IMO. Regards, Jim