Re: [Libvir] [patch 9/9] Implement better error reporting
On Tue, Feb 20, 2007 at 03:08:13PM +0000, Mark McLoughlin wrote:
On Mon, 2007-02-19 at 18:00 +0000, Mark McLoughlin wrote:
> Okay, here's an attempt to clean up all this code - mostly to coalesce
> the two system vs. user code paths into a single function, but also to
> recursively create config dirs and fix up the problems you spotted.
I went ahead and committed that assuming no responses meant no-one had
a problem with it.
Yep, forgot to reply :-)
Here's a further patch to make us only attempt to create config
dirs
when configs are being saved.
I'm in two minds about this. On the one hand if your starting the system
QEMU daemon from an init script, creating the config dirs on startup gives
admin immediate feedback of any problems. On the other hand, the per-user
instance is auto-started so they'd never see a failure message during
startup. I guess if we can reliably feedback errors to the user about
failing to create the config dirs, this patch is a plus.
Dan.
--
|=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=|
|=- Perl modules: http://search.cpan.org/~danberr/ -=|
|=- Projects: http://freshmeat.net/~danielpb/ -=|
|=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|