Re: [Libvir] 4/8 Enable the <config.h>-requiring test; fix violations
"Richard W.M. Jones" <rjones(a)redhat.com> wrote:
Jim Meyering wrote:
> Enable the <config.h>-requiring test; fix violations
>
> Use <config.h>, not "config.h", per autoconf documentation.
> * Makefile.cfg (local-checks-to-skip) [sc_require_config_h]: Enable.
> * .x-sc_require_config_h: New file, to list exempted files.
> * Makefile.am (EXTRA_DIST): Add .x-sc_require_config_h.
>
> Signed-off-by: Jim Meyering <meyering(a)redhat.com>
> ---
> .x-sc_require_config_h | 5 +++++
> ChangeLog | 8 ++++----
We actually patch the Changelog file. Is that a good idea?
ACK to the rest.
Good catch.
I'll add an exclusion (list ChangeLog in .x-sc_require_config_h)