Re: [libvirt] [libvirt-snmp][PATCH v4 4/4] Add SNMP trap/notification support.
On 04/01/2011 01:17 PM, Daniel P. Berrange wrote:
On Wed, Mar 30, 2011 at 01:20:30PM +0200, Michal Privoznik wrote:
> This patch adds support for domain lifecycle notification support
> over SNMP traps. SNMP subagent monitors any domain events and when
> something interesting happens, it sends a trap.
>
> Monitoring is done in a joinable thread using polling (used
> domain-events example from libvirt) so we won't block the agent itself.
>
> Some debug info can be printed out by setting LIBVIRT_SNMP_VERBOSE
> environment variable.
> ---
> src/event.c | 193 ++++++++++++
> src/event.h | 101 ++++++
You don't want to be copying those files. They are libvirt's
internal event driver setup code. You just want to be providing
an implementation fir that, which is what the next two files
do:
> src/event_poll.c | 724 ++++++++++++++++++++++++++++++++++++++++++++
> src/event_poll.h | 132 ++++++++
Yes, they are libvirt internal. But if i need to copy implementation of
functions which uses another internals, e.g. virEventPollRunOnce() calls
virMutexLock, virThreadSelf, etc. i need to provide them as well, don't
i? This is why i copied so much.
Or did i miss something?
Regards,
Daniel
Michal