Re: [PATCH v6 3/4] remove sysconfig files
On Tue, Jan 11, 2022 at 09:56:30AM +0000, Daniel P. Berrangé wrote:
On Tue, Jan 11, 2022 at 09:51:05AM +0000, Andrea Bolognani wrote:
> On Tue, Jan 11, 2022 at 10:21:32AM +0100, Olaf Hering wrote:
> > Mon, 3 Jan 2022 03:18:11 -0800 Andrea Bolognani <abologna(a)redhat.com>:
> > > The fact that we still QEMU_AUDIO_DRV and SDL_AUDIODRIVER in the
> > > service file even after your changes goes against this principle.
> >
> > So what should be done about these?
> >
> > I think whoever added support for these environment variables a couple
> > of decades ago failed to provide proper documentation. Or perhaps
> > whoever wrote the "sound" section of formatdomain.html.in failed to
> > recognize the existence of these environment variables.
>
> Dan, do you think it would be okay to simply drop these from the
> service/sysconfig file? IIUC we have a proper way to set them on a
> per-domain level now.
I don't think we need todo anything differentl - Olaf's patches
are fine in this respect already IMHO. Certainly we don't need
to add more documentation about these than already exists as we
don't need to encourage more usage.
Right, I got a bit caught up in the details and sort of lost track of
the initial discussion. I never had a problem with Olaf's changes
with respect to those variable, as they basically maintain the status
quo. But, what you're saying is that there are still valid use cases
for setting those in the service file, and we can't quite get rid of
them yet - or possibly ever?
--
Andrea Bolognani / Red Hat / Virtualization