Re: [libvirt] [PATCH] qemu: assign USB port on a selected hub for all devices

On 01/27/2017 12:17 PM, Ján Tomko wrote:

Due to a logic error, the autofilling of USB port when a bus is specified: <address type='usb' bus='0'/> does not work for non-hub devices on domain startup.

Fix the logic in qemuDomainAssignUSBPortsIterator to also assign ports for USB addresses that do not yet have one.

https://bugzilla.redhat.com/show_bug.cgi?id=1374128 --- src/qemu/qemu_domain_address.c | 7 ++++++- tests/qemuxml2argvdata/qemuxml2argv-usb-port-missing.args | 2 +- 2 files changed, 7 insertions(+), 2 deletions(-)

ACK (seems reasonable) John