On Fri, 2015-11-20 at 11:33 -0500, Laine Stump wrote:
Seems safe, but is this really what we want to do? I haven't read/understood the remaining patches yet, but this makes it sound like what is going to happen is that all of the devices will be unbound from vfio-pci immediately, so they are "in limbo", and will then be reprobed once all devices are unused (and therefore unbound from vfio-pci).
I think that may be a bit dangerous. Instead, we should leave the devices bound to vfio-pci until all of them are unused, and at that time, we should unbind them all from vfio-pci, then reprobe them all. (again, I may have misunderstood the direction, if so ignore this).
I agree, we should not unbind any device from vfio-pci until all the devices in the IOMMU group have been detached from the guest. Cheers. -- Andrea Bolognani Software Engineer - Virtualization Team