Re: [libvirt] [PATCH] vircapstest: Avoid (im)possible strcmp call with NULL argument

On 11/13/2017 10:44 PM, Jiri Denemark wrote:

Some compiler may get confused and decide we are calling strcmp with NULL argument from test_virCapsDomainDataLookupLXC. Although this does not really happen since the call is guarded with (data->machinetype != expect_machinetype), using STRNEQ_NULLABLE is easier to understand, less fragile, and doing so makes sure strcmp is never called with NULL argument.

Signed-off-by: Jiri Denemark <jdenemar@redhat.com> --- tests/vircapstest.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)

ACK Michal