9:14 a.m.
Rather than picking apart the two pieces we need/want (path, hosts,
and auth)- let's allocate/use a virStorageSourcePtr for iSCSI storage.
The end result is that qemuBuildSCSIiSCSIHostdevDrvStr doesn't need
to "fake" one for the qemuBuildNetworkDriveStr call.
Signed-off-by: John Ferlan <jferlan(a)redhat.com>
---
src/conf/domain_conf.c | 46 +++++++++++++++++++++++++---------------------
src/conf/domain_conf.h | 5 +----
src/qemu/qemu_command.c | 10 +---------
src/qemu/qemu_domain.c | 9 +++++----
src/qemu/qemu_hotplug.c | 2 +-
5 files changed, 33 insertions(+), 39 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index e34e8f4d0f..33b06f33e4 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -2475,10 +2475,9 @@
virDomainHostdevSubsysSCSIiSCSIClear(virDomainHostdevSubsysSCSIiSCSIPtr iscsisrc
{
if (!iscsisrc)
return;
- VIR_FREE(iscsisrc->path);
- virStorageNetHostDefFree(iscsisrc->nhosts, iscsisrc->hosts);
- virStorageAuthDefFree(iscsisrc->auth);
- iscsisrc->auth = NULL;
+
+ virStorageSourceFree(iscsisrc->src);
+ iscsisrc->src = NULL;
}
@@ -4352,7 +4351,7 @@ virDomainHostdevDefPostParse(virDomainHostdevDefPtr dev,
if (scsisrc->protocol == VIR_DOMAIN_HOSTDEV_SCSI_PROTOCOL_TYPE_ISCSI) {
virDomainHostdevSubsysSCSIiSCSIPtr iscsisrc = &scsisrc->u.iscsi;
- if (virDomainPostParseCheckISCSIPath(&iscsisrc->path) < 0)
+ if (virDomainPostParseCheckISCSIPath(&iscsisrc->src->path) < 0)
return -1;
}
@@ -7118,24 +7117,29 @@ virDomainHostdevSubsysSCSIiSCSIDefParseXML(xmlNodePtr sourcenode,
virStorageAuthDefPtr authdef = NULL;
virDomainHostdevSubsysSCSIiSCSIPtr iscsisrc = &def->u.iscsi;
- /* Similar to virDomainDiskSourceParse for a VIR_STORAGE_TYPE_NETWORK */
+ /* For the purposes of command line creation, this needs to look
+ * like a disk storage source */
+ if (VIR_ALLOC(iscsisrc->src) < 0)
+ return -1;
+ iscsisrc->src->type = VIR_STORAGE_TYPE_NETWORK;
+ iscsisrc->src->protocol = VIR_STORAGE_NET_PROTOCOL_ISCSI;
- if (!(iscsisrc->path = virXMLPropString(sourcenode, "name"))) {
+ if (!(iscsisrc->src->path = virXMLPropString(sourcenode, "name"))) {
virReportError(VIR_ERR_XML_ERROR, "%s",
_("missing iSCSI hostdev source path name"));
goto cleanup;
}
- if (virDomainStorageNetworkParseHosts(sourcenode, &iscsisrc->hosts,
- &iscsisrc->nhosts) < 0)
+ if (virDomainStorageNetworkParseHosts(sourcenode, &iscsisrc->src->hosts,
+ &iscsisrc->src->nhosts) < 0)
goto cleanup;
- if (iscsisrc->nhosts < 1) {
+ if (iscsisrc->src->nhosts < 1) {
virReportError(VIR_ERR_XML_ERROR, "%s",
_("missing the host address for the iSCSI hostdev"));
goto cleanup;
}
- if (iscsisrc->nhosts > 1) {
+ if (iscsisrc->src->nhosts > 1) {
virReportError(VIR_ERR_XML_ERROR, "%s",
_("only one source host address may be specified "
"for the iSCSI hostdev"));
@@ -7161,7 +7165,7 @@ virDomainHostdevSubsysSCSIiSCSIDefParseXML(xmlNodePtr sourcenode,
authdef->secrettype);
goto cleanup;
}
- iscsisrc->auth = authdef;
+ iscsisrc->src->auth = authdef;
authdef = NULL;
}
cur = cur->next;
@@ -15667,9 +15671,9 @@ virDomainHostdevMatchSubsysSCSIiSCSI(virDomainHostdevDefPtr
first,
virDomainHostdevSubsysSCSIiSCSIPtr second_iscsisrc =
&second->source.subsys.u.scsi.u.iscsi;
- if (STREQ(first_iscsisrc->hosts[0].name, second_iscsisrc->hosts[0].name)
&&
- first_iscsisrc->hosts[0].port == second_iscsisrc->hosts[0].port &&
- STREQ(first_iscsisrc->path, second_iscsisrc->path))
+ if (STREQ(first_iscsisrc->src->hosts[0].name,
second_iscsisrc->src->hosts[0].name) &&
+ first_iscsisrc->src->hosts[0].port ==
second_iscsisrc->src->hosts[0].port &&
+ STREQ(first_iscsisrc->src->path, second_iscsisrc->src->path))
return 1;
return 0;
}
@@ -23018,7 +23022,7 @@ virDomainHostdevDefFormatSubsys(virBufferPtr buf,
virDomainHostdevSubsysSCSIProtocolTypeToString(scsisrc->protocol);
virBufferAsprintf(buf, " protocol='%s' name='%s'",
- protocol, iscsisrc->path);
+ protocol, iscsisrc->src->path);
}
if (def->source.subsys.type == VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_SCSI_HOST) {
@@ -23070,9 +23074,9 @@ virDomainHostdevDefFormatSubsys(virBufferPtr buf,
case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_SCSI:
if (scsisrc->protocol == VIR_DOMAIN_HOSTDEV_SCSI_PROTOCOL_TYPE_ISCSI) {
virBufferAddLit(buf, "<host");
- virBufferEscapeString(buf, " name='%s'",
iscsisrc->hosts[0].name);
- if (iscsisrc->hosts[0].port)
- virBufferAsprintf(buf, " port='%u'",
iscsisrc->hosts[0].port);
+ virBufferEscapeString(buf, " name='%s'",
iscsisrc->src->hosts[0].name);
+ if (iscsisrc->src->hosts[0].port)
+ virBufferAsprintf(buf, " port='%u'",
iscsisrc->src->hosts[0].port);
virBufferAddLit(buf, "/>\n");
} else {
virBufferAsprintf(buf, "<adapter name='%s'/>\n",
@@ -23099,8 +23103,8 @@ virDomainHostdevDefFormatSubsys(virBufferPtr buf,
if (def->source.subsys.type == VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_SCSI &&
scsisrc->protocol == VIR_DOMAIN_HOSTDEV_SCSI_PROTOCOL_TYPE_ISCSI &&
- iscsisrc->auth) {
- if (virStorageAuthDefFormat(buf, iscsisrc->auth) < 0)
+ iscsisrc->src->auth) {
+ if (virStorageAuthDefFormat(buf, iscsisrc->src->auth) < 0)
return -1;
}
diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h
index 38de70b154..ee9d06c5e9 100644
--- a/src/conf/domain_conf.h
+++ b/src/conf/domain_conf.h
@@ -357,10 +357,7 @@ struct _virDomainHostdevSubsysSCSIHost {
typedef struct _virDomainHostdevSubsysSCSIiSCSI virDomainHostdevSubsysSCSIiSCSI;
typedef virDomainHostdevSubsysSCSIiSCSI *virDomainHostdevSubsysSCSIiSCSIPtr;
struct _virDomainHostdevSubsysSCSIiSCSI {
- char *path;
- size_t nhosts;
- virStorageNetHostDefPtr hosts;
- virStorageAuthDefPtr auth;
+ virStorageSourcePtr src;
};
typedef struct _virDomainHostdevSubsysSCSI virDomainHostdevSubsysSCSI;
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 8708b79ed0..76130c3de1 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -4950,21 +4950,13 @@ static char *
qemuBuildSCSIiSCSIHostdevDrvStr(virDomainHostdevDefPtr dev)
{
char *source = NULL;
- virStorageSource src;
qemuDomainHostdevPrivatePtr hostdevPriv = QEMU_DOMAIN_HOSTDEV_PRIVATE(dev);
- memset(&src, 0, sizeof(src));
-
virDomainHostdevSubsysSCSIPtr scsisrc = &dev->source.subsys.u.scsi;
virDomainHostdevSubsysSCSIiSCSIPtr iscsisrc = &scsisrc->u.iscsi;
- src.protocol = VIR_STORAGE_NET_PROTOCOL_ISCSI;
- src.path = iscsisrc->path;
- src.hosts = iscsisrc->hosts;
- src.nhosts = iscsisrc->nhosts;
-
/* Rather than pull what we think we want - use the network disk code */
- source = qemuBuildNetworkDriveStr(&src, hostdevPriv->secinfo);
+ source = qemuBuildNetworkDriveStr(iscsisrc->src, hostdevPriv->secinfo);
return source;
}
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index b248a3ddc4..3bdb22314c 100644
--- a/src/qemu/qemu_domain.c
+++ b/src/qemu/qemu_domain.c
@@ -1490,9 +1490,10 @@ qemuDomainSecretHostdevPrepare(virConnectPtr conn,
if (virHostdevIsSCSIDevice(hostdev)) {
virDomainHostdevSubsysSCSIPtr scsisrc = &hostdev->source.subsys.u.scsi;
virDomainHostdevSubsysSCSIiSCSIPtr iscsisrc = &scsisrc->u.iscsi;
+ virStorageSourcePtr src = iscsisrc->src;
if (scsisrc->protocol == VIR_DOMAIN_HOSTDEV_SCSI_PROTOCOL_TYPE_ISCSI
&&
- iscsisrc->auth) {
+ src->auth) {
qemuDomainHostdevPrivatePtr hostdevPriv =
QEMU_DOMAIN_HOSTDEV_PRIVATE(hostdev);
@@ -1500,8 +1501,8 @@ qemuDomainSecretHostdevPrepare(virConnectPtr conn,
if (!(hostdevPriv->secinfo =
qemuDomainSecretInfoNew(conn, priv, hostdev->info->alias,
VIR_SECRET_USAGE_TYPE_ISCSI,
- iscsisrc->auth->username,
- &iscsisrc->auth->seclookupdef,
+ src->auth->username,
+ &src->auth->seclookupdef,
false)))
return -1;
}
@@ -8157,7 +8158,7 @@ qemuDomainGetHostdevPath(virDomainDefPtr def,
/* Follow qemuSetupDiskCgroup() and qemuSetImageCgroupInternal()
* which does nothing for non local storage
*/
- VIR_DEBUG("Not updating /dev for hostdev iSCSI path
'%s'", iscsisrc->path);
+ VIR_DEBUG("Not updating /dev for hostdev iSCSI path
'%s'", iscsisrc->src->path);
} else {
virDomainHostdevSubsysSCSIHostPtr scsihostsrc = &scsisrc->u.host;
scsi = virSCSIDeviceNew(NULL,
diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c
index e4157f631d..ad274a9959 100644
--- a/src/qemu/qemu_hotplug.c
+++ b/src/qemu/qemu_hotplug.c
@@ -4888,7 +4888,7 @@ int qemuDomainDetachHostDevice(virQEMUDriverPtr driver,
virDomainHostdevSubsysSCSIiSCSIPtr iscsisrc = &scsisrc->u.iscsi;
virReportError(VIR_ERR_OPERATION_FAILED,
_("host scsi iSCSI path %s not found"),
- iscsisrc->path);
+ iscsisrc->src->path);
} else {
virDomainHostdevSubsysSCSIHostPtr scsihostsrc =
&scsisrc->u.host;
--
2.13.6