Re: [libvirt] [PATCH] command: plug memory leak
2010/12/10 Eric Blake <eblake(a)redhat.com>:
* src/util/command.c (virCommandFree): Free data from
virCommandSetInputBuffer.
---
src/util/command.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/src/util/command.c b/src/util/command.c
index 089e0bd..5e2b19a 100644
--- a/src/util/command.c
+++ b/src/util/command.c
@@ -1198,6 +1198,7 @@ virCommandFree(virCommandPtr cmd)
}
}
+ VIR_FREE(cmd->inbuf);
VIR_FORCE_CLOSE(cmd->outfd);
VIR_FORCE_CLOSE(cmd->errfd);
At first I wanted to complain that virCommandSetInputBuffer isn't
documented to take ownership of the inbuf, then I saw that it's
strdup'ed :)
ACK.
Matthias