On Tue, Feb 22, 2022 at 08:38:10AM +0100, Michal Prívozník wrote:
On 2/21/22 17:17, Andrea Bolognani wrote:
On Mon, Feb 21, 2022 at 04:10:25PM +0100, Michal Privoznik wrote:
+VIR_ENUM_IMPL(qemuMonitorDirtyRateCalcMode, + QEMU_MONITOR_DIRTYRATE_CALC_MODE_LAST, + "page-sampling", + "dirty-bitmap", + "dirty-ring", +);
Kinda weird that this one ends up in the middle of the file instead of being grouped with the rest. I'd keep them together, unless there's a good reason for doing things this way that I missed.
My idea was to keep it close to the rest of dirty rate related functions. But I can move it next to the rest. I don't have strong preference.
I don't have a strong preference either. Just push it as is :) -- Andrea Bolognani / Red Hat / Virtualization