Re: [libvirt] [PATCH v3 1/3] numatune: add check for numatune nodeset range

On Thu, Oct 30, 2014 at 02:23:00AM +0000, Chen, Fan wrote: >On Wed, 2014-10-29 at 14:20 +0100, Martin Kletzander wrote: >> On Wed, Oct 29, 2014 at 08:33:32PM +0800, Chen Fan wrote: >> >diff --git a/src/util/virnuma.c b/src/util/virnuma.c >> >@@ -373,6 +400,12 @@ virNumaGetNodeCPUs(int node ATTRIBUTE_UNUSED, >> > _("NUMA isn't available on this host")); >> > return -1; >> > } >> >+ >> >+bool >> >+virNumaNodesetIsAvailable(virDomainNumatunePtr numatune) >> >+{ >> >+ return true; >> >+} >> > #endif >> > >> >> In what case would you like this to return true? > >when libvirt does not support numa, we can not check it. >maybe we should return false if setting nodeset. > That was my idea, I just wanted to make sure we're on the same page. The thing is that if you want something that's not available, it makes more sense to say "NO" then just allow it because libvirt doesn't know. Make the user fix it :)

Martin