Re: [libvirt] [PATCH] xen: prefer XS in xenUnifiedListDomains
On Thu, Nov 27, 2008 at 05:04:05PM +0100, Guido G?nther wrote:
On Tue, Nov 25, 2008 at 11:39:57AM +0000, Daniel P. Berrange wrote:
> Yeha, this is almost certainly just another example of XenD not properly
> cleaning up / destroying domains. If you still have a machine which
> shows this behaviour, then I'd recommend trying this change to our Xen
> impl
>
> In xen_unified.c, find the method xenUnifiedListDomains and make it first
> call xenStoreListDomains() and then fallback to trying HV & XenD drivers.
> If we're lucky this will help....
Yes this helps indeed, thanks a lot. Possible patch attached.
Thanks for confirming. ACK to this patch - it looks reasonable to
me, and shouldn't have any serious performance implication.
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|