[libvirt] [PATCH 2/3] zfs: Resolve RESOURCE_LEAK
Found by my Coverity checker - virCheckFlags call could return -1, but
not virCommandFree(destroy_cmd).
Signed-off-by: John Ferlan <jferlan(a)redhat.com>
---
src/storage/storage_backend_zfs.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/storage/storage_backend_zfs.c b/src/storage/storage_backend_zfs.c
index 6bf7963..4d04c70 100644
--- a/src/storage/storage_backend_zfs.c
+++ b/src/storage/storage_backend_zfs.c
@@ -355,10 +355,12 @@ virStorageBackendZFSDeleteVol(virConnectPtr conn ATTRIBUTE_UNUSED,
unsigned int flags)
{
int ret = -1;
- virCommandPtr destroy_cmd = virCommandNewArgList(ZFS, "destroy", NULL);
+ virCommandPtr destroy_cmd = NULL;
virCheckFlags(0, -1);
+ destroy_cmd = virCommandNewArgList(ZFS, "destroy", NULL);
+
virCommandAddArgFormat(destroy_cmd, "%s/%s",
pool->def->source.name, vol->name);
--
2.5.0