Re: [PATCH v2 04/17] qemu: Improve qemuDomainDefaultSCSIControllerModel()

On Wed, Feb 14, 2024 at 18:11:11 +0100, Andrea Bolognani wrote: > In order to have a nice API while still keeping the > implementation short and readable, a small wrapper is required. Well arguably the wrapper is not needed unless you really want to use: return VIR_DOMAIN_CONTROLLER_MODEL_SCS*; rather than: *model = VIR_DOMAIN_CONTROLLER_MODEL_SCS*; return 0;

So now this always returns 0 -> success, thus the return value is pointless. Further up the next patch which modifies the documentation still keeps the claim. Additionally the description will read: Not being able to come up with a value is NOT considered a failure. which will mean that this function will never fail. IMO it would be sufficient to just declare: virDomainControllerModelSCSI qemuDomainDefaultSCSIControllerModel(const virDomainDef *def, const virDomainControllerDef *cont, ... and just document the same claims. Thus if _DEFAULT is returned it's up to the caller to decide. Fabricating a return value doesn't seem to make much sense for me and once you only return success you might as well as return the value directly. It'd simplify the checker conditions.