Re: [libvirt] [PATCH] libvirt_setuid_rpc_client_la: Link APPARMOR libs

On 10/22/2013 11:23 AM, Michal Privoznik wrote: > The libvirt_setuid_rpc_client_la depends on vircommand.c, in which we > are conditionally calling aa_change_profile() - an AppArmor helper > function. However, in linking the libvirt-setuid-rpc-client.la we have > forgot to link AppArmor libraries leaving us with following error: > > make[3]: Entering directory `/home/zippy/work/libvirt/libvirt.git/tools' > CCLD virsh > CCLD virt-host-validate > CCLD virt-login-shell > ../src/.libs/libvirt-setuid-rpc-client.a(libvirt_setuid_rpc_client_la-vircommand.o): In function `virExec': > /home/zippy/work/libvirt/libvirt.git/src/util/vircommand.c:653: undefined reference to `aa_change_profile' > collect2: error: ld returned 1 exit status > make[3]: *** [virt-login-shell] Error 1 > make[3]: *** Waiting for unfinished jobs.... > > Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com&gt; > --- > src/Makefile.am | 12 ++++++++---- > 1 file changed, 8 insertions(+), 4 deletions(-) >

NACK; I think Jim's patch (version 2 at https://www.redhat.com/archives/libvir-list/2013-October/msg00953.html) addresses the same problem in a nicer manner.