Re: [libvirt] [PATCH v3 0/2] Empty first lines series
On Fri, Jun 06, 2014 at 06:44:07AM -0600, Eric Blake wrote:
On 06/06/2014 03:20 AM, Martin Kletzander wrote:
> v3 -- use the whole VC_LIST_EXCEPT, create exception for necessities
> and clear the rest
>
> v2 -- s/FILENAME:1:/FILENAME ":1:"/
>
>
> Martin Kletzander (2):
> Remove unnecessary empty first lines
> maint: prohibit empty first lines
>
> cfg.mk | 10 ++++++++++
> docs/generic.css | 1 -
> docs/libvirt.css | 2 --
> src/locking/lockd.conf | 1 -
> src/locking/sanlock.conf | 1 -
> tests/nodeinfodata/linux-test3/node/node0/meminfo | 1 -
Was this (and similar) file copied from an actual sysfs output? If so,
and if sysfs includes the leading blank lines, then we should exempt
these files rather than touching them up.
There are more files like this, about half of them had the first line
empty and half of them hadn't. I tested that there is no difference
between those two and also checked, on systems I came to contact with,
that there is no empty line in that file.
Otherwise, ACK series.
Thanks, pushed already after review from Dan.
Martin
Attachments:
- signature.asc (application/pgp-signature — 836 bytes)