I was able to get this to build with some tweaking, that in the end used the updated patch, but was using this patch all along, and found the first patch didn't work.

http://meatwad.mouf.net/rubick/poudriere/logs/bulk/92i386-jgh/2013-12-30_08h29m34s/logs/py27-libvirt-1.2.0.log

Here is a link to the code for the port: (under the files directory is the patch)
https://svn.redports.org/jgh/devel/py-libvirt/

-jgh


On Sun, Dec 29, 2013 at 3:21 PM, Jason Helfman <jgh@freebsd.org> wrote:
I will try it out. Please open a new account here:
http://redports.org, and that should be sufficient enough. It will build on new commits, and I can help with the port.

I can also help justify the account, if that is needed.
Thanks!
-jgh


On Sun, Dec 29, 2013 at 2:59 PM, Doug Goldstein <cardoe@gentoo.org> wrote:
On Sun, Dec 29, 2013 at 12:42 PM, Jason Helfman <jgh@freebsd.org> wrote:
> Any ideas?

I just posted a patch with the subject of "[PATCH python] define
__GNUC_PREREQ macro before using it" [1]. Give it a shot and let me
know if that fixes the issue.

Additionally, if you can potentially provide a FreeBSD machine that we
can use as a BuildBot [2] for libvirt-python, that would likely
prevent problems in the future. You can see the BB here [3].

[1] https://www.redhat.com/archives/libvir-list/2013-December/msg01317.html
[2] http://buildbot.net
[3] http://bb.cardoe.com/libvirt-python/

>
> Clang: FreeBSD clang version 3.1
>
> creating build/temp.freebsd-9.1-RELEASE-p4-i386-2.7
> creating build/temp.freebsd-9.1-RELEASE-p4-i386-2.7/build
> clang -DNDEBUG -O2 -pipe -fno-strict-aliasing -O2 -pipe -fno-strict-aliasing
> -fPIC -I. -I/usr/local/include/python2.7 -c libvirt-override.c -o
> build/temp.freebsd-9.1-RELEASE-p4-i386-2.7/libvirt-override.o
> -I/usr/local/include
> In file included from libvirt-override.c:26:
> ./libvirt-utils.h:87:22: error: token is not a valid binary operator in a
> preprocessor subexpression
> #   if __GNUC_PREREQ (3, 3)
>        ~~~~~~~~~~~~~ ^
> ./libvirt-utils.h:99:22: error: token is not a valid binary operator in a
> preprocessor subexpression
> #   if __GNUC_PREREQ (3, 4)
>        ~~~~~~~~~~~~~ ^
> 2 errors generated.
> error: command 'clang' failed with exit status 1
> *** [do-build] Error code 1
>
> Stop in /usr/home/jgh/workspace/ports/devel/py-libvirt.
>
>
> Gcc: gcc (GCC) 4.2.1 20070831
> gcc -DNDEBUG -O2 -pipe -fno-strict-aliasing -O2 -pipe -fno-strict-aliasing
> -fPIC -I. -I/usr/local/include/python2.7 -c libvirt-override.c -o
> build/temp.freebsd-9.1-RELEASE-p4-i386-2.7/libvirt-override.o
> -I/usr/local/include
> In file included from libvirt-override.c:26:
> libvirt-utils.h:87:22: error: missing binary operator before token "("
> libvirt-utils.h:99:22: error: missing binary operator before token "("
> error: command 'gcc' failed with exit status 1
> *** [do-build] Error code 1
>
>
> Thanks!
> -jgh
> --
> Jason Helfman          | FreeBSD Committer
> jgh@FreeBSD.org     | http://people.freebsd.org/~jgh  | The Power to Serve
>
> --
> libvir-list mailing list
> libvir-list@redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list

--
Doug Goldstein




--
Jason Helfman          | FreeBSD Committer
jgh@FreeBSD.org     | http://people.freebsd.org/~jgh  | The Power to Serve



--
Jason Helfman          | FreeBSD Committer
jgh@FreeBSD.org     | http://people.freebsd.org/~jgh  | The Power to Serve