On Thu, Mar 18, 2010 at 08:35:18AM -0600, Eric Blake wrote:
On 03/18/2010 05:17 AM, Jiri Denemark wrote:
+ res = strtod(arg->data, &end_p);
Should we be using the gnulib strtod module here?
Why? It doesn't seem to be any better than C89 strtod. Or did I miss anything?
strtod is broken on a number of platforms in various ways; most of them related to parsing the new formats required by C99, but there are some other bugs even with C89 parsing as well:
http://git.sv.gnu.org/cgit/gnulib.git/tree/doc/posix-functions/strtod.texi
Actually, virsh should be using virStrToDouble(). If there are issues with strtod(),then virStrToDouble is the place to fix them, using gnulib for it if applicable Regards Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|