On Tue, Dec 16, 2008 at 05:11:10PM +0300, Anton Protopopov wrote:
As a general rule the public virDomainPtr objects should not be passed down into internal methods. Likewise, when creating / defining a VM, the virGetDomain call should be the last one in the normal execution path of the method.
Thus, just pass the 'virConnectPtr' instance to openvzDomainSetVcpusInternal as suggested above, and keep the setVcpusInternal calls above the call to virGetDomain.
OK, done.
Thanks I've comited this patch Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|