Re: [libvirt] [PATCH] virsh: Insert error messages to avoid a quiet abortion of commands

On 03/14/2011 09:33 AM, Eric Blake wrote: Actually, all your other changes were where pre-patch had < 0, so you were already prepared to deal with an optional argument. But for cmdConnect, you changed <= 0 to < 0, you now go on to the rest of the method with name still NULL, which causes problems on the subsequent strdup(). But an empty string for the URI is valid (it means the same as a NULL URI for requesting the default connection). Yet vshCommandOptString rejects the empty string. I'm pushing your patch as-is, but we need another followup for commands that specifically want to handle the empty string (such as cmdConnect) in a manner other than just rejecting it. -- Eric Blake eblake(a)redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org