Re: [libvirt] [PATCH 1/2] qemu: Fix @vm locking issue when connecting to the monitor

On 10/9/19 11:42 PM, Jonathon Jongsma wrote:

This change gives me a segfault at startup when running libvirtd from my working directory. Reverting these two patches solves the issue.

Oops, yes. The qemuProcessQMPConnectMonitor() needs the same treatement as qemuMonitorCommonTestNew(). Since it's a trivial fix, I'll push it shortly. Thanks for reporting this. <rant> We should probably teach virDomainObjIsActive() to rely on vm->state rather than vm->def->id. </rant> Michal