On 11/4/19 3:55 PM, Miguel Ángel Arruga Vivas wrote:
Hi everybody,
The following patches try to enhance the support for non-systemd configurations.
The first patch just removes the references to the cgroups created by systemd, only leaving the reference to /machine cgroup, created by libvirtd for hosted virtual machines.
The second one ensures the creation of that group when using cgroups-v2, as the error message provided in bug report[1] is raised by checking too early the existence of the file cgroup.controllers, before the actual creation of the control group. I tried to solve it at the highest abstraction level, by chaining properly the object construction.
Happy hacking! Miguel
[1] https://bugzilla.redhat.com/show_bug.cgi?id=1760233
Miguel Ángel Arruga Vivas (2): doc: cgroups: Remove unwanted references to systemd vircgroup: Ensure /machine group is associated with its parent
docs/cgroups.html.in | 13 +++---------- src/util/vircgroup.c | 8 +++++--- 2 files changed, 8 insertions(+), 13 deletions(-)
Reviewed-by: Michal Privoznik <mprivozn@redhat.com> and pushed. I've tested on my non-systemd machine and everything works just fine. Congratulations on your first libvirt contribution. Michal