Re: [libvirt] [PATCH 2/1] selinux: enhance test to cover nfs label failure

Eric Blake wrote: > Daniel Berrange (correctly) pointed out that we should do a better > job of testing selinux labeling fallbacks on NFS disks that lack > labeling support. > FYI, this is causing a build failure on a host without libattr-devel make[2]: Entering directory `/home/jfehlig/virt/upstream/libvirt/tests' CCLD libshunload.la CC securityselinuxhelper.lo securityselinuxhelper.c:34:24: fatal error: attr/xattr.h: No such file or directory compilation terminated. make[2]: *** [securityselinuxhelper.lo] Error 1

> +/* This file is only compiled on Linux, and only if xattr support was > + * detected. */ > + > +#include <dlfcn.h> > +#include <errno.h> > +#include <linux/magic.h> > #include <selinux/selinux.h> > +#include <stdio.h> > #include <stdlib.h> > #include <string.h> > +#include <sys/vfs.h> > #include <unistd.h> > -#include <errno.h> > -#if WITH_ATTR > -# include <attr/xattr.h> > -#endif > +#include <attr/xattr.h>