On Fri, Oct 02, 2020 at 04:47:59PM +0200, Peter Krempa wrote:
On Fri, Oct 02, 2020 at 15:12:45 +0100, Daniel Berrange wrote:
> Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com>
> ---
[...]
> diff --git a/docs/manpages/virt-login-shell.rst
b/docs/manpages/virt-login-shell.rst
> index 3833a3e912..1e95d5d2b4 100644
> --- a/docs/manpages/virt-login-shell.rst
> +++ b/docs/manpages/virt-login-shell.rst
> @@ -29,7 +29,7 @@ configured in ``/etc/libvirt/virt-login-shell.conf``.
>
> The basic structure of most ``virt-login-shell`` usage is:
>
> -.. code-block::
> +.. code-block:: shell
>
> virt-login-shell
>
> @@ -58,7 +58,7 @@ By default, ``virt-login-shell`` will execute the ``/bin/sh``
program for
> the user. You can modify this behaviour by defining the shell variable in
> ``/etc/libvirt/virt-login-shell.conf``. e.g.
>
> -.. code-block::
> +.. code-block:: shell
>
> shell = [ "/bin/bash" ]
>
> @@ -68,7 +68,7 @@ detect the shell from ``/etc/password`` inside the container. This
should only
> be done if the container has a separate ``/etc`` directory from the host,
> otherwise it will end up recursively invoking ``virt-login-shell``. e.g.
>
> -.. code-block::
> +.. code-block:: shell
>
> auto_shell = 1
>
> @@ -77,7 +77,7 @@ By default no users are allowed to use virt-login-shell, if you
want to allow
> certain users to use virt-login-shell, you need to modify the allowed_users
> variable in /etc/libvirt/virt-login-shell.conf. e.g.
>
> -.. code-block::
> +.. code-block:: shell
>
> allowed_users = [ "tom", "dick", "harry" ]
This doesn't seem to belong to this patch.
Opps, yes, clearly wrong.
With the changes to the above file dropped:
Reviewed-by: Peter Krempa <pkrempa(a)redhat.com>
Regards,
Daniel
--
|:
https://berrange.com -o-
https://www.flickr.com/photos/dberrange :|
|:
https://libvirt.org -o-
https://fstop138.berrange.com :|
|:
https://entangle-photo.org -o-
https://www.instagram.com/dberrange :|