On Mon, Mar 30, 2009 at 12:52:48PM +0100, Daniel P. Berrange wrote:
I ran the OOM checking test suite again and uncovered a handful of
pretty minor bugs - no crashers in real code - just forgetting to
report OOM correctly
* src/datatypes.c: Convert to use the virReportErrorHelper macro
instead of a static function, so we get correct function/line
number info
* src/domain_conf.c: Fix OOM handling in virXPathNodeSet() call
so it reports OOM error, instead of ignoring
* src/nodeinfo.c: Use _(...) for error message strings
* src/xend_internal.c: Add missing check of virBufferError() func
and report OOM error
* tests/sexpr2xmltest.c: Reset error object between tests, free
capabilities object, don't unref a NULL connection object
* tests/testutils.c: Fix crash in OOM testing if single threaded
* tests/xml2sexprtest.c: Reset error object between tests
All look fine, patch included, ACK
thanks !
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit
http://xmlsoft.org/
daniel(a)veillard.com | Rpmfind RPM search engine
http://rpmfind.net/
http://veillard.com/ | virtualization library
http://libvirt.org/