Re: [libvirt] [PATCH 2/2] qemu: Add support for zero-detection writes

2015-12-14 15:44 GMT+03:00 Vasiliy Tolstov <v.tolstov(a)selfip.ru&gt;: > Thanks, i'm try to test this patch series and get error: > ОШИБКА: internal error: process exited while connecting to monitor: > 2015-12-14T12:36:44.438611Z qemu-system-x86_64: -drive > file=/dev/vg3/41459,if=none,id=drive-scsi0-0-0-0,format=raw,cache=none,discard=unmap,detect_zeros=unmap,aio=native: > Block format 'raw' used by device 'drive-scsi0-0-0-0' doesn't support > the option 'detect_zeros'

this is patch for patch =) diff --git a/debian/patches/libvirt-qemu-detect-zeros.patch b/debian/patches/libvirt-qemu-detect-zeros.patch index 582c49d..d86dee6 100644 --- a/debian/patches/libvirt-qemu-detect-zeros.patch +++ b/debian/patches/libvirt-qemu-detect-zeros.patch @@ -130,7 +130,7 @@ index d2f37e408bab..49b76adc416f 100644 + if (disk->detect_zeros) { + if (virQEMUCapsGet(qemuCaps, QEMU_CAPS_DRIVE_DETECT_ZEROS)) { -+ virBufferAsprintf(&opt, ",detect_zeros=%s", ++ virBufferAsprintf(&opt, ",detect-zeroes=%s", + virDomainDiskDetectZerosTypeToString(disk->detect_zeros)); + } else { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", @@ -198,11 +198,11 @@ index 000000000000..5224a69798b2 +-boot dc \ +-usb \ +-drive file=/var/lib/libvirt/images/f14.img,if=none,id=drive-virtio-disk0,\ -+format=qcow2,discard=unmap,detect_zeroes=unmap \ ++format=qcow2,discard=unmap,detect-zeroes=unmap \ +-device virtio-blk-pci,bus=pci.0,addr=0x4,drive=drive-virtio-disk0,\ +id=virtio-disk0 \ +-drive file=/var/lib/libvirt/Fedora-14-x86_64-Live-KDE.iso,if=none,media=cdrom,\ -+id=drive-ide0-1-0,format=raw,discard=ignore,detect_zeroes=off \ ++id=drive-ide0-1-0,format=raw,discard=ignore,detect-zeroes=off \ +-device ide-drive,bus=ide.1,unit=0,drive=drive-ide0-1-0,id=ide0-1-0 \ +-device virtio-balloon-pci,id=balloon0,bus=pci.0,addr=0x3 diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c -- Vasiliy Tolstov, e-mail: v.tolstov(a)selfip.ru