Re: [libvirt] [PATCH v2 04/10] conf: stop passing virConnectPtr into virDomainDiskTranslateSourcePool
On 02/15/2018 11:50 AM, Daniel P. Berrangé wrote:
Rather than expecting callers to pass a virConnectPtr into the
virDomainDiskTranslateSourcePool() method, just acquire a connection
to the storage driver when needed.
Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com>
---
src/conf/domain_conf.c | 10 +++++++---
src/conf/domain_conf.h | 3 +--
src/qemu/qemu_conf.c | 3 +--
src/qemu/qemu_conf.h | 3 +--
src/qemu/qemu_driver.c | 39 ++++++++++++++++-----------------------
src/qemu/qemu_hotplug.c | 2 +-
src/qemu/qemu_process.c | 4 ++--
tests/qemuxml2argvtest.c | 5 +++++
8 files changed, 34 insertions(+), 35 deletions(-)
Reviewed-by: John Ferlan <jferlan(a)redhat.com>
John
FWIW:
I've been trying to run the avocado tests as an "extra" way to ensure
nothing has been messed up, but something (before this series) has
caused my virt-install to be less than happy <sigh> - I'm sure some of
it is self inflicted, but the error is making me wonder:
2018-02-16 02:07:55.517+0000: 31492: error :
qemuProcessReportLogError:1928 : internal error: qemu unexpectedly
closed the monitor: 2018-02-16T02:07:55.479523Z qemu-system-x86_64:
can't apply global Haswell-noTSX-x86_64-cpu.spec-ctrl=on: Property
'.spec-ctrl' not found
I also tried running the virt-manager tests, but running from top of
tree fails with the urllib.parse failure:
...
File "/home/jferlan/github/virt-manager/tests/__init__.py", line 33,
in <module>
from tests import utils
File "/home/jferlan/github/virt-manager/tests/utils.py", line 21, in
<module>
import virtinst
File "/home/jferlan/github/virt-manager/virtinst/__init__.py", line
41, in <module>
from virtinst.uri import URI
File "/home/jferlan/github/virt-manager/virtinst/uri.py", line 22, in
<module>
import urllib.parse
ImportError: No module named parse
I narrowed it down to commit '3086c7fd' via git bisect and sent an email
to Cole. <sigh>