Re: [libvirt] [PATCH 1/4] lxc: validate tty pid before kill()
On Thu, May 29, 2008 at 03:20:05PM -0700, Dave Leskovec wrote:
This patch adds a check of the tty forwarding process pid before
kill()'ing it
when destroying a domain. If the pid value stored in the the vm structure is
invalid, sending a SIGKILL may be very bad if the value in question is something
like -1 (which just happens to be it's initial value).
Sanity test looks fine to me, sure, +1
Daniel
--
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard | virtualization library http://libvirt.org/
veillard(a)redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/