v2: - modified explanation of why virStorageSourceIsSameLocation was called with NULL - fixed the call to virStorageSourceGetMetadata which caused the NULL deref - fixed permission issue when calling qemu-img if files are owned by root:root after restoring seclabels - improved error message when generating snapshot path fails (not related to original bug, just annoying when I've had a messed up VM) Peter Krempa (5): qemuSnapshotDiskHasBackingDisk: Avoid call of virStorageSourceIsSameLocation with NULL argument qemuSnapshotUpdateBackingStore: Remove stale comment qemuSnapshotDiskHasBackingDisk: Use proper 'max_depth' when calling 'virStorageSourceGetMetadata' virDomainSnapshotDefAssignExternalNames: Improve error message qemuSnapshotUpdateBackingStore: Retry as curent user if qemu-img fails src/conf/snapshot_conf.c | 4 +-- src/qemu/qemu_domain.c | 2 -- src/qemu/qemu_domain.h | 1 + src/qemu/qemu_snapshot.c | 61 ++++++++++++++++++++++++++++------------ 4 files changed, 46 insertions(+), 22 deletions(-) -- 2.52.0