On 8/3/23 12:36, Michal Privoznik wrote:
This is a residue of v6.8.0-rc1~100. The error variable inside of virFirewallDApplyRule() is already initialized to NULL. There's no need to memset() it to zero again.
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Claudio Fontana <cfontana@suse.de>
--- src/util/virfirewalld.c | 2 -- 1 file changed, 2 deletions(-)
diff --git a/src/util/virfirewalld.c b/src/util/virfirewalld.c index 6fc54f357d..827e201dbb 100644 --- a/src/util/virfirewalld.c +++ b/src/util/virfirewalld.c @@ -360,8 +360,6 @@ virFirewallDApplyRule(virFirewallLayer layer, if (!sysbus) return -1;
- memset(&error, 0, sizeof(error)); -
It was a quite convoluted way to just set a pointer to NULL ...
if (!ipv) { virReportError(VIR_ERR_INTERNAL_ERROR, _("Unknown firewall layer %1$d"),