Re: [libvirt] [PATCH]: don't hardcode default port 22 for ssh protocol
On Fri, Jan 30, 2009 at 09:53:54PM +0100, Guido Günther wrote:
Hi,
attached patch removes the hardcoded port 22 when going through ssh, ssh
uses it by default. This makes it easier to override this via
.ssh/config on a per host basis instead of having to add this to the
connection URI explicitly.
While at that I cleaned up some free vs. VIR_FREE usage and replaced
pointer intializations with 0 by NULL.
Honnestly this looks fine, but I didn't really had a way to test the
patch prior to the 0.6.0 release, so I didn't commited it before. I
guess this will make the next release :-\
P.S.: this originated from Debian Bug #513605
A complete URL is a bit easier to use ;-)
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library http://libvirt.org/