On 09/12/2013 08:00 PM, lawrancejing wrote:
There is no need to go on executing code when the array's length
is zero.
---
tools/virsh-snapshot.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/tools/virsh-snapshot.c b/tools/virsh-snapshot.c
index e37a5b3..d7a4c7b 100644
--- a/tools/virsh-snapshot.c
+++ b/tools/virsh-snapshot.c
@@ -239,7 +239,7 @@ vshParseSnapshotMemspec(vshControl *ctl, virBufferPtr buf, const char
*str)
return 0;
narray = vshStringToArray(str, &array);
- if (narray < 0)
+ if (narray <= 0)
goto cleanup;
Makes no difference. narray == 0 is not a possible return value from
vshStringToArray, which always returns -1 or a positive number.
Therefore, I don't see the need to apply this.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library
http://libvirt.org