26 Sep
2011
26 Sep
'11
6:39 p.m.
On 09/26/2011 03:45 PM, Eric Blake wrote:
It can be seen that the <domain></domain> indent correctly.
I typed 'make check' in the tests directory. The domainsnapshotxml2xmltest part output: TEST: domainsnapshotxml2xmltest ...... 6 OK PASS: domainsnapshotxml2xmltest
I'll take that as a series ack, and push the 14 patches then.
Actually, I'd feel more comfortable also getting a code review, and not just a compile- and runtime-check test, since I am modifying some internal APIs, and since I may have overlooked some lines not covered by the particular <domain> that you tested. -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org