Re: [libvirt] [PATCHv2 10/17] conf: new pci controller model "pcie-root-port"

>> @@ -18914,6 +18941,12 @@ virDomainControllerDefFormat(virBufferPtr buf, >> if (def->opts.pciopts.chassisNr != -1) >> virBufferAsprintf(buf, " chassisNr='%d'", >> def->opts.pciopts.chassisNr); >> + if (def->opts.pciopts.chassis != -1) >> + virBufferAsprintf(buf, " chassis='%d'", >> + def->opts.pciopts.chassis); >> + if (def->opts.pciopts.port != -1) >> + virBufferAsprintf(buf, " port='0x%x'", >> + def->opts.pciopts.port); > OH... And this is what I get for not reading ahead... So now my previous > comments are unfounded... <sigh> Which comments are those? There was a comment in a previous patch about not needing the boolean "pciTarget" that wasn't valid, but your comments about the range were certainly valid.