Re: Remove rpath from RPMs
On Sat, Oct 10, 2020 at 06:11:53PM +0300, Daniel Letai wrote:
Hi,
Attached see simple patch to remove rpath during meson build, so rpmbuild
on redhat/fedora based distros don't complain.
Seeing as all rpaths are in standard locations, this seems safe to me.
This was supposed to have been fixed by
commit 69980ab798e240923ef12f86a92665b6c9ff7292
Author: Andrea Bolognani <abologna(a)redhat.com>
Date: Wed Aug 19 11:15:35 2020 +0200
however that overlooked that %meson macro adds --auto-features=enabled,
which caused the rpath to be force enabled in the RPM build.
>From 6622771b2f595b293e8872a44bfceb7f2097e4a5 Mon Sep 17 00:00:00
2001
From: Daniel Letai <dani(a)letai.org.il>
Date: Sat, 10 Oct 2020 18:02:13 +0300
Subject: [PATCH] Remove rpath from rpms
---
libvirt.spec.in | 1 +
1 file changed, 1 insertion(+)
diff --git a/libvirt.spec.in b/libvirt.spec.in
index edf919d7ba..7e356bb843 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -1184,6 +1184,7 @@ export SOURCE_DATE_EPOCH=$(stat --printf='%Y'
%{_specdir}/%{name}.spec)
-Dinit_script=systemd \
-Ddocs=enabled \
-Dtests=enabled \
+ -Drpath=disabled \
%{?arg_login_shell}
so yeah, we need this.
Reviewed-by: Daniel P. Berrangé <berrange(a)redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|