Re: [libvirt] [PATCH 1/3] utils: Implement virCommandPassFDGetFDIndex

On Mon, Feb 23, 2015 at 06:50:46AM -0500, Stefan Berger wrote: > Implement virCommandPassFDGetFDIndex to determine the index a given > file descriptor will have when passed to the child process. When this > function is called, a flag is set to prevent the reordering of the > file descriptors. > > Signed-off-by: Stefan Berger <stefanb(a)linux.vnet.ibm.com&gt; > --- > src/libvirt_private.syms | 1 + > src/util/vircommand.c | 33 +++++++++++++++++++++++++++++++++ > src/util/vircommand.h | 3 +++ > 3 files changed, 37 insertions(+) > > diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms > index c156b40..aadb833 100644 > --- a/src/libvirt_private.syms > +++ b/src/libvirt_private.syms > @@ -1213,6 +1213,7 @@ virCommandNewArgList; > virCommandNewArgs; > virCommandNonblockingFDs; > virCommandPassFD; > +virCommandPassFDGetFDIndex; > virCommandPassListenFDs; > virCommandRawStatus; > virCommandRequireHandshake; > diff --git a/src/util/vircommand.c b/src/util/vircommand.c > index 6527d85..2616446 100644 > --- a/src/util/vircommand.c > +++ b/src/util/vircommand.c > @@ -67,6 +67,7 @@ enum { > VIR_EXEC_RUN_SYNC = (1 << 3), > VIR_EXEC_ASYNC_IO = (1 << 4), > VIR_EXEC_LISTEN_FDS = (1 << 5), > + VIR_EXEC_FIXED_FDS = (1 << 6), The descriptors shouldn't get reordered *unless* there is VIR_EXEC_LISTEN_FDS flag added, so FIXED_FDS shouldn't be necessary. Or is there a bug in that approach that needs fixing?